Conversation
dsseng
force-pushed
the
pcapng-io
branch
3 times, most recently
from
1a841c3 to
8d47c73
Compare
| try: | ||
| import pyzstd | ||
| except ImportError: | ||
| pyzstd = None |
There was a problem hiding this comment.
Zstandard addition should be a distinct commit. Please let me know if you would like to merge with squashing so that I can split it out into a new PR
It is useful for both using SocketCAN devices and pcap(ng) files storing SocketCAN packets
|
Keep the changes minimal. Move the socketcan files back to where they belong, remove zstd and all other unrelated changes. Add test data and documentation (see file_io.rst) |
I abstracted out some common SocketCAN files for the purpose of not duplicating the code. pcapng expects packets to be serialized as SocketCAN packets, so this code has to be shared. Let me know if there is a better place or way to refactor this. |
|
you could just import from socketcan without moving the files |
Is this a correct pattern for an IO module to import an interface module? That felt a bit counter-logical |
2 participants
This PR adds support for Pcapng files to the I/O module
Related to #1403, pcap should be rather simple to implement based on these changes.
TODO:
lz4, zst, perhaps other compression types readers know about